Propogation of SIGTSTP ?

[Chris Samuel]

On Tue, 12 Apr 2005 09:52 pm, Sébastien Georget wrote:

Hi Sébastien, that's a very useful patch!

One minor nit I'm afraid:

> +    if (sig == 18)
> +        notify_tasks(18);
> +    if (sig == 20)
> +        notify_tasks(19);

These Linux specific signal numbers aren't portable, it would be much better 
to replace the number values with the symbols from <signal.h>

For instance, whilst SIGTSTP is 20 on Linux, it's 18 on Tru64 as 20 is SIGCHLD 
there..

So that little bit would probably be:

+    if (sig == SIGCONT)
+        notify_tasks(SIGCONT);
+    if (sig == SIGTSTP)
+        notify_tasks(SIGSTOP);

Of course, this relies on Torque also being patched to send SIGTSTP instead of 
SIGSTOP when doing suspends (as you can't catch SIGSTOP).

cheers!
Chris
-- 
 Christopher Samuel - (03)9925 4751 - VPAC Deputy Systems Manager
 Victorian Partnership for Advanced Computing http://www.vpac.org/
 Bldg 91, 110 Victoria Street, Carlton South, VIC 3053, Australia

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://email.osc.edu/pipermail/mpiexec/attachments/20050414/1aab809a/attachment.bin